Skip to content

chore(go): add performance benchmark#1983

Merged
josecorella merged 45 commits intomainfrom
benchmark
Jan 21, 2026
Merged

chore(go): add performance benchmark#1983
josecorella merged 45 commits intomainfrom
benchmark

Conversation

@rishav-karanjit
Copy link
Member

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@rishav-karanjit rishav-karanjit changed the title chore(go): add performance benchmark wip: add performance benchmark Sep 8, 2025
@github-actions
Copy link

github-actions bot commented Sep 9, 2025

Detected changes to the release files or to the check-files action

@github-actions
Copy link

github-actions bot commented Sep 9, 2025

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

@github-actions
Copy link

github-actions bot commented Sep 9, 2025

Detected changes to the release files or to the check-files action

@github-actions
Copy link

github-actions bot commented Sep 9, 2025

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

@josecorella josecorella changed the title wip: add performance benchmark chore(go): add performance benchmark Jan 13, 2026
Copy link
Contributor

@ShubhamChaturvedi7 ShubhamChaturvedi7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor stuff.

- 102400 # 100KB
- 512000 # 500KB
- 1048576 # 1MB
- 10000000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was the conversation about MegaBytes and MebiBytes - In any case, aws refers MB as 2^10 so we can drop the 10^6 values (would reduce suite runtime).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it here: 729bd37

return nil
}

func (b *DBESDKBenchmark) SetupDDB(partitionKey, sortKeyName, allowedUnsignedAttributePrefix string, algorithmSuiteID mpltypes.DBEAlgorithmSuiteId, attributeActions map[string]dbesdkstructuredencryptiontypes.CryptoAction) error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we want to test the e2e call as well but I'll leave it to you

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave it out for now - the e2e network latency is not something too important to measure atm

return nil
}

type resolverV2 struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it even being used?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope. I will leave it in tho if we ever want to measure the e2e performance

@josecorella josecorella marked this pull request as ready for review January 20, 2026 20:07
@josecorella josecorella requested a review from a team as a code owner January 20, 2026 20:07
josecorella and others added 3 commits January 20, 2026 12:50
Added a new medium data size of 1MB and removed an extra large data size.
Copy link
Contributor

@ShubhamChaturvedi7 ShubhamChaturvedi7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed - made a commit but added to the branch directly, unintentionally

729bd37

@josecorella if this looks good to you, then it LGTM.

Copy link
Contributor

@lucasmcdonald3 lucasmcdonald3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploying to CFN LGTM

@josecorella josecorella merged commit 928e318 into main Jan 21, 2026
83 of 92 checks passed
@josecorella josecorella deleted the benchmark branch January 21, 2026 01:48
josecorella pushed a commit that referenced this pull request Feb 6, 2026
* **java:** drop hkdf offset method ([#2011](#2011)) ([b8f29f9](b8f29f9))

* Add go to smithy dependencies ([#1986](#1986)) ([066c0ca](066c0ca))
* add managed policy to cfn template ([#2012](#2012)) ([915183d](915183d))
* bump mpl ([#1953](#1953)) ([4e295f9](4e295f9))
* bump MPL and reuse release script from MPL   ([#1963](#1963)) ([eb52fca](eb52fca))
* bump mpl and smithy dafny ([#1982](#1982)) ([c71fc82](c71fc82))
* bump mpl to allow nightly build ([#1984](#1984)) ([208eb31](208eb31))
* **cfn:** add DescribeTable permission ([#1952](#1952)) ([f24a0d3](f24a0d3))
* **CI:** add slack notifications  ([#1964](#1964)) ([139c856](139c856))
* **CI:** fix dafny_interop to setup_net ([#1965](#1965)) ([e7a5a02](e7a5a02))
* **CI:** remove redundant dotnet run ([#2038](#2038)) ([09c3266](09c3266))
* **dafny:** bump MPL and update mutable map ([#1974](#1974)) ([e9ea870](e9ea870))
* **dafny:** bump smithy dafny  ([#1971](#1971)) ([85309a0](85309a0))
* **deps:** update aws-lc-sys requirement ([#2019](#2019)) ([c397bf2](c397bf2))
* fix non prod daily CI for Go ([#2006](#2006)) ([f8d8f08](f8d8f08))
* fix non-prod.yml ([#2007](#2007)) ([43b5163](43b5163))
* **go:** Add client supplier and basic put get example  ([#1950](#1950)) ([2e36410](2e36410))
* **go:** add complex example in searchable encryptions ([#1955](#1955)) ([012ebf9](012ebf9))
* **go:** Add Go release workflow and script   ([#1958](#1958)) ([2fe77ab](2fe77ab))
* **go:** add performance benchmark ([#1983](#1983)) ([928e318](928e318))
* **go:** add plain text migration examples  ([#1966](#1966)) ([c8796d9](c8796d9))
* **go:** add Searchable Encryption Examples ([#1951](#1951)) ([07bdbe7](07bdbe7))
* **go:** Add various keyrings examples in Go ([#1948](#1948)) ([ffb0c38](ffb0c38))
* **go:** fix nit in go-release workflow ([#1978](#1978)) ([45f7f15](45f7f15))
* **go:** Update ci_test_go.yml ([#1970](#1970)) ([b373067](b373067))
* **go:** update go test matrix and clean up setup ([#1959](#1959)) ([7dd705b](7dd705b))
* **java:** Allow local testing ([#1947](#1947)) ([bf5a106](bf5a106))
* **java:** fix GetEncryptedDataKeyDescription java Example  ([#1973](#1973)) ([ba8fcb7](ba8fcb7))
* move go out of pull/push/daily into its own ([#2005](#2005)) ([1b961b5](1b961b5))
* **net:** Add plaintext to encrypted table migration example ([#1976](#1976)) ([814acbf](814acbf))
* remove test against latest mpl version ([#2008](#2008)) ([728158e](728158e))
* **rust:** add plaintext to encrypted table migration examples   ([#1977](#1977)) ([5286619](5286619))
* **rust:** add simple performance benchmarks ([#2027](#2027)) ([a5bdeb7](a5bdeb7))
* **rust:** bump mpl to remove rust warnings ([#1993](#1993)) ([4d16a62](4d16a62))
* **rust:** fips feature ([#1980](#1980)) ([516fd3d](516fd3d))
* **rust:** improved blocking ([#2030](#2030)) ([162c86c](162c86c))
* **rust:** prepare release of 1.2.0 ([#1981](#1981)) ([5a2569a](5a2569a))
* **rust:** release 1.2.1 ([#2004](#2004)) ([47f6cd9](47f6cd9))
* **rust:** release 1.2.2 ([#2035](#2035)) ([cacda77](cacda77))
* **rust:** use Dafny 4.10.0 for Rust codegen ([#1995](#1995)) ([95168a2](95168a2))
* **TestVectors:** add config tests for new attributes ([#1967](#1967)) ([4017a97](4017a97))
* update check-files ([#2041](#2041)) ([0bafe07](0bafe07))
* update mpl ([#1991](#1991)) ([fed53bf](fed53bf))
* use macos-14 for CI ([#1998](#1998)) ([e0d2b77](e0d2b77))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants